Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default RSS docs url + Allow docs override #97

Merged
merged 4 commits into from
Aug 11, 2019
Merged

Change default RSS docs url + Allow docs override #97

merged 4 commits into from
Aug 11, 2019

Conversation

sonniesedge
Copy link
Contributor

This will change the default value a feeds doc attribute from http://blogs.law.harvard.edu/tech/rss to https://validator.w3.org/feed/docs/rss2.html.

Both documents contain the same content, so this is a URL-only change.

I propose that this is less confusing for new users. I myself spent a few minutes wondering why my feed had a reference to a random university law blog, and assumed my content had got contaminated. 😂

The new URL is the top result on Google for "RSS 2.0 specification" and references w3.org, which should hopefully offer a better clue to future users like me!

@sonniesedge sonniesedge changed the title Change default docs url to RSS2 spec at W3.org Change default docs url and allow override Aug 7, 2019
@coveralls
Copy link

coveralls commented Aug 7, 2019

Coverage Status

Coverage remained the same at 95.109% when pulling 9d6eedb on sonniesedge:patch-1 into 5b85277 on jpmonette:master.

@jpmonette
Copy link
Owner

@sonniesedge I don't think the w3c documentation existed when I first created this module - thanks for the PR!

@jpmonette jpmonette merged commit af01083 into jpmonette:master Aug 11, 2019
@jpmonette jpmonette changed the title Change default docs url and allow override Change default RSS docs url + Allow docs override Aug 11, 2019
@sonniesedge sonniesedge deleted the patch-1 branch August 11, 2019 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants